Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating table word-break syntax docs #8335

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Oct 29, 2024

Why are you making this change? (required)

Per accessibility requirements, the syntax for resetting table breaks has been updated. Note the addition of role="presentation".

Old:

{: .reset-td-br-1 .reset-td-br-2 }

New:

{: .reset-td-br-1 .reset-td-br-2 role="presentation" }

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 11:22pm

@josh-mccrowell-braze
Copy link
Collaborator

Looks good! Thanks for putting this together. This is still in a draft stage so I did not merge it immediately, but I'm glad you thought of this instance.

@internetisaiah internetisaiah marked this pull request as ready for review October 30, 2024 15:09
@internetisaiah internetisaiah merged commit e875460 into develop Oct 30, 2024
5 checks passed
@internetisaiah internetisaiah deleted the updating-table-syntax-refs branch October 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants