-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DI-6749] Restore the autogenerated Currents events docs #8349
[DI-6749] Restore the autogenerated Currents events docs #8349
Conversation
.tool-versions
Outdated
@@ -0,0 +1 @@ | |||
ruby 3.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this update intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, no--just added it to get rake to work locally. Removed.
@isturdy is attempting to deploy a commit to the Braze team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
…com:braze-inc/braze-docs into di-6749-restore-autogenerated-currents-docs fix
@rachel-feinberg is attempting to deploy a commit to the Braze team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through for a Docs review! LGTM
@josh-mccrowell-braze @rachel-feinberg who do we need to merge this? |
@flybonzai I merged it in! 😄 |
Why are you making this change? (required)
This adds payload documentation for non-Storage Currents destinations, as well as fixing numerous cases where the existing docs had fallen out of sync with what we actually send.
Related PRs, issues, or features (optional)
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.