-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content audit: Message building by channel #8357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Leaving this open if you want another set of eyes on it!
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently reviewing now, but just leaving a reminder to update file names to more closely match your new title / nav_title
. For example message_building_by_channel/email/drag_and_drop/overview.md
could be changed to message_building_by_channel/email/drag_and_drop/create.md
(or similiar). Be sure to set up a redirect as well 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some general feedback + I changed one file as an example. (Although I think my changes are only applicable to one other page in your PR--not all of them).
Great job overall! Thanks for helping make our docs better. Let me know if you have any questions 👍🏽
(P.S. thanks for all that sweet sweet alt text).
_docs/_user_guide/message_building_by_channel/email/drag_and_drop/overview.md
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/email/drag_and_drop/overview.md
Outdated
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/email/drag_and_drop/overview.md
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/email/drag_and_drop/overview.md
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/email/drag_and_drop/overview.md
Outdated
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/email/html_editor/creating_an_email_campaign.md
Show resolved
Hide resolved
_docs/_user_guide/message_building_by_channel/webhooks/creating_a_webhook.md
Show resolved
Hide resolved
@lydia-xie is attempting to deploy a commit to the Braze team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
_docs/_user_guide/message_building_by_channel/email/drag_and_drop/overview.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why are you making this change? (required)
Related PRs, issues, or features (optional)
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.