Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content audit: Message building by channel #8357

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Content audit: Message building by channel #8357

merged 6 commits into from
Nov 7, 2024

Conversation

lydia-xie
Copy link
Contributor

@lydia-xie lydia-xie commented Nov 1, 2024

Why are you making this change? (required)

  • Related to my OKR work for Q3, this is a content audit for Message building by channel with edits to the steps workflow and updated images

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Leaving this open if you want another set of eyes on it!

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 8:39pm

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently reviewing now, but just leaving a reminder to update file names to more closely match your new title / nav_title. For example message_building_by_channel/email/drag_and_drop/overview.md could be changed to message_building_by_channel/email/drag_and_drop/create.md (or similiar). Be sure to set up a redirect as well 👍🏽

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some general feedback + I changed one file as an example. (Although I think my changes are only applicable to one other page in your PR--not all of them).

Great job overall! Thanks for helping make our docs better. Let me know if you have any questions 👍🏽

(P.S. thanks for all that sweet sweet alt text).

Copy link

vercel bot commented Nov 7, 2024

@lydia-xie is attempting to deploy a commit to the Braze team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @lydia-xie as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @lydia-xie as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Braze team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@internetisaiah internetisaiah merged commit dd00d4f into develop Nov 7, 2024
5 checks passed
@internetisaiah internetisaiah deleted the lx-mc branch November 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants