Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-4650 / Nudge android docs to use async getCurrentUser method #8369

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

radixdev
Copy link
Contributor

@radixdev radixdev commented Nov 5, 2024

Why are you making this change? (required)

https://jira.braze.com/browse/SDK-4650

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

vercel bot commented Nov 5, 2024

@radixdev is attempting to deploy a commit to the Braze team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @radixdev as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @radixdev as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Braze team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

@radixdev radixdev requested a review from a team November 5, 2024 21:12
@radixdev radixdev marked this pull request as ready for review November 5, 2024 21:12
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 11:44pm

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@internetisaiah internetisaiah merged commit b2be48b into develop Nov 6, 2024
5 checks passed
@internetisaiah internetisaiah deleted the SDK-4650/nudge-towards-async-get-user branch November 6, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants