Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relevant information from KB articles #8436

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Add relevant information from KB articles #8436

merged 5 commits into from
Nov 15, 2024

Conversation

lydia-xie
Copy link
Contributor

Why are you making this change? (required)

Adding relevant information to email, Canvas, and campaign articles

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@lydia-xie lydia-xie self-assigned this Nov 15, 2024
@cla-bot cla-bot bot added the cla-signed label Nov 15, 2024
Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Left a few small suggestions

…ies/best_practices.md

Co-authored-by: Rachel Feinberg <135255868+rachel-feinberg@users.noreply.github.com>
Copy link

vercel bot commented Nov 15, 2024

@lydia-xie is attempting to deploy a commit to the Braze team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @lydia-xie as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @lydia-xie as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Braze team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

lydia-xie and others added 3 commits November 15, 2024 15:48
…ies/best_practices.md

Co-authored-by: Rachel Feinberg <135255868+rachel-feinberg@users.noreply.github.com>
…il_footer.md

Co-authored-by: Rachel Feinberg <135255868+rachel-feinberg@users.noreply.github.com>
…il_footer.md

Co-authored-by: Rachel Feinberg <135255868+rachel-feinberg@users.noreply.github.com>
@lydia-xie lydia-xie merged commit 54a9df0 into develop Nov 15, 2024
1 of 4 checks passed
@lydia-xie lydia-xie deleted the lx-kb-edits branch November 15, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants