Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3712 Update message engagement event abort type #8538

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

rachel-feinberg
Copy link
Contributor

@rachel-feinberg rachel-feinberg commented Dec 3, 2024

Why are you making this change? (required)

Update the message engagement events definition for "abort_type" to remove example values. There are currently about 30 example values, and the current definition implies there are only a few.

Related PRs, issues, or features (optional)

BD-3712

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure if you need to verify with a SME on the details. Feel free to merge whenever you're ready 👍🏽

@rachel-feinberg rachel-feinberg merged commit 81eeb71 into develop Dec 3, 2024
5 checks passed
@rachel-feinberg rachel-feinberg deleted the bd-3712 branch December 3, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants