Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-3303] Clarify CDN directives for Web SDK #8556

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Dec 4, 2024

Why are you making this change? (required)

From ticket:

We list the braze CDN url as required for img-src but if a user is using custom fonts, for example, in In-App Messages, they'll need font-src to include the braze CDN url as well.

Note: I converted the sections to use tables instead as it makes copying and pasting much easier for readers (now you just need to triple-click in the cell instead of manually highlighting with mouse).

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@internetisaiah internetisaiah merged commit 91a6209 into develop Dec 5, 2024
5 checks passed
@internetisaiah internetisaiah deleted the BD-3303 branch December 5, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants