Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Currents] Remove claim about dynamic allow listing from Currents documentation - DI-6172 #8562

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ferrous26
Copy link
Contributor

@ferrous26 ferrous26 commented Dec 5, 2024

Why are you making this change? (required)

We had a PQ come in that was asking about dynamic allow listing for Currents. This ends up being confusing for customers since it seems to imply features that our partners would have to provide.

And since our partners do not provide this feature, we definitely should not claim that it exists.

Related PRs, issues, or features (optional)

https://servicedesk.braze.com/browse/PQ-6789

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

cla-bot bot commented Dec 5, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

@ferrous26
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2024
Copy link

cla-bot bot commented Dec 5, 2024

The cla-bot has been summoned, and re-checked this pull request!

@ferrous26 ferrous26 requested review from rachel-feinberg, a team, isturdy, darthryking and flybonzai and removed request for a team December 5, 2024 15:20
Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@rachel-feinberg rachel-feinberg merged commit deaab61 into develop Dec 6, 2024
1 check passed
@rachel-feinberg rachel-feinberg deleted the currants/remove-erroneous-doc-claim branch December 6, 2024 17:36
@ferrous26 ferrous26 changed the title [Currents] Remove claim about dynamic allow listing from Currents documentation - PQ-6789 [Currents] Remove claim about dynamic allow listing from Currents documentation - DI-6172 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants