Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require a newer version of Sphinx #416

Closed
alfredodeza opened this issue Feb 8, 2019 · 6 comments · Fixed by #419
Closed

require a newer version of Sphinx #416

alfredodeza opened this issue Feb 8, 2019 · 6 comments · Fixed by #419
Assignees
Labels
bug Problem in existing code code Source code

Comments

@alfredodeza
Copy link

The requirement for Sphinx is set to:

Sphinx>=1.4

But since this commit: 1799bb9d it is no longer possible to use Sphinx that is 1.8.4 or older (see sphinx-doc/sphinx@6d52b63eee)

If an environment with anything 1.8.4 or older will break with:

AttributeError: 'module' object has no attribute 'CPPUnionObject'
@vermeeren vermeeren added bug Problem in existing code code Source code labels Feb 8, 2019
@vermeeren
Copy link
Collaborator

Yeah, it appears this should be changed to Sphinx>=1.8. I'll do this soon, thanks for reporting!

@vermeeren vermeeren self-assigned this Feb 8, 2019
@t-b
Copy link
Contributor

t-b commented Feb 8, 2019

@melvinvermeeren While you are at it, why not add a requirements.txt for pip?

@alfredodeza
Copy link
Author

what would the requirements.txt provide that setup.py doesn't @t-b ?

@t-b
Copy link
Contributor

t-b commented Feb 9, 2019

@alfredodeza With a requirements.txt developers can just do pip install -r requirements.txt to install the dependencies, setup.py does not help here. See also https://stackoverflow.com/a/43659126.

@vermeeren
Copy link
Collaborator

the requirements.txt appears to be inside requirements/production.txt, though it is also outdated, will fix this too while I'm at it

@vermeeren
Copy link
Collaborator

could you review the PR and see if this is fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem in existing code code Source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants