-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support titles in verbatim blocks #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lshamis I notice in tests/test_renderer.py:94
there is currently a dummy nested_parse
, I think we should also change that one to match the change to nested_parse_with_titles()
.
The doc you linked makes it kinda obvious, this method is indeed just better without any downsides. Probably appeared in some later Sphinx version sometime ago.
@vermeeren I'm not sure how to replace the one at
class MockState:
def __init__(self, app):
env = sphinx.environment.BuildEnvironment(app)
env.setup(app)
env.temp_data['docname'] = 'mock-doc'
settings = frontend.OptionParser(
components=(parsers.rst.Parser,)).get_default_values()
settings.env = env
self.document = utils.new_document('', settings)
def nested_parse(self, content, content_offset, contentnode): # <-- :94
pass |
@lshamis My bad, I wasn't fully awake when I posted it. I believe it is safe to remove the Do you think it is better to keep the |
Removing
|
Suspected that could happen, everything is fine then as-is. |
Released as 4.18.0. |
#516
https://www.sphinx-doc.org/en/master/extdev/markupapi.html#viewlists