Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common Moonpay provider #1046

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add common Moonpay provider #1046

merged 1 commit into from
Jul 18, 2024

Conversation

dangeross
Copy link
Collaborator

This PR:

  • Moves the Moonpay provider into sdk-common.
  • Adds optional fixed or max amounts to the Moonpay request.
  • Adds an optional redirect_url param to the BuyBitcoinRequest to support setting of a custom redirectURL.

Fixes #912

@dangeross dangeross requested review from roeierez and ok300 July 17, 2024 09:43
This was referenced Jul 17, 2024
Closed
Merged
roeierez
roeierez approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross merged commit 8e4f846 into main Jul 18, 2024
9 checks passed
@dangeross dangeross deleted the savage-common-buy-provider branch July 18, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ok300 ok300 ok300 approved these changes

@roeierez roeierez roeierez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moonpay: Add ability to set custom redirectURL on complete
3 participants
@dangeross @roeierez @ok300