Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist LNURL-pay comment sent to the recipient #941

Merged
merged 2 commits into from
May 2, 2024
Merged

Persist LNURL-pay comment sent to the recipient #941

merged 2 commits into from
May 2, 2024

Conversation

andrei-21
Copy link
Contributor

@andrei-21 andrei-21 commented Apr 19, 2024 •
edited
Loading

We want to persist and expose the comment the user sends to the recipient when using LNURL-pay. Do you like this approach?

@dangeross
Copy link
Collaborator

I think this is a good way to do it.

I would note the PR still needs:

  • the bindings UDL file updating so the field is exposed to the generated bindings
  • a table migration adding to the database

@andrei-21 andrei-21 force-pushed the feature/perisit-lnurl-pay-comment branch from d034d29 to 99512ed Compare April 19, 2024 12:28
@andrei-21 andrei-21 marked this pull request as ready for review April 19, 2024 12:28
@andrei-21
Copy link
Contributor Author

andrei-21 commented Apr 24, 2024 •
edited
Loading

The PR is ready for review. Thanks.

dangeross
dangeross reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you run the flutter and react native code generators on the PR also?

dangeross
dangeross approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross requested a review from roeierez April 24, 2024 15:16
roeierez
roeierez approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit f8a57ab into breez:main May 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ok300 ok300 ok300 approved these changes

@roeierez roeierez roeierez approved these changes

@dangeross dangeross dangeross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrei-21 @dangeross @roeierez @ok300 @danielgranhao