New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show local balance for closed channel payments #964

Merged

roeierez merged 2 commits into main from local-balance

May 7, 2024

Member

roeierez commented May 7, 2024

Currently the amount of the payment info corresponding to a closed channels is taken from the spendable_msat which on cases when the remote force closes the channel might be less than the local balance on the channel (right before the close).
The reason for it being less is because it is taken into account the sweep transaction fees.
Instead we take now the to_us_msat which is the right value.
fixes https://github.com/Blockstream/blockstream_breez_issues/issues/34
fixes https://github.com/Blockstream/blockstream_breez_issues/issues/29

roeierez added 2 commits

May 7, 2024 15:27


          persist local_balance on channels

ed948c6


          remove sql logs

e17dd68

roeierez requested a review from ok300

May 7, 2024 12:33

ok300 approved these changes

View reviewed changes

roeierez merged commit 21bd2ae into main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet