Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTTP status code check in GET response parsing #990

Merged
merged 2 commits into from
May 27, 2024
Merged

Allow HTTP status code check in GET response parsing #990

merged 2 commits into from
May 27, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented May 27, 2024

We want to support two kinds of GET response parsing:

  • first, where an error HTTP status code results automatically in Err (mempool.space, boltz API)
  • second, where the HTTP status code is not checked, but we attempt to parse the payload into possibly an error payload (LNURL)

This PR adds support for the first type, in addition to the second which was already supported.

@ok300 ok300 requested review from roeierez and dangeross May 27, 2024 05:21
@ok300 ok300 mentioned this pull request May 27, 2024
Merged
roeierez
roeierez requested changes May 27, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A small comment.

libs/sdk-core/src/input_parser.rs Outdated Show resolved Hide resolved
@ok300 ok300 merged commit ad08487 into chain-service-error May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez requested changes

@dangeross dangeross Awaiting requested review from dangeross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ok300 @roeierez