Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindings-kotlin-multiplatform to use version catalog #997

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

angelix
Copy link
Collaborator

@angelix angelix commented Jun 7, 2024

Update dependencies

atomicfu = "0.24.0"
android-gradle-plugin = "8.4.1"
jna = "5.14.0"
kotlin = "1.9.24"
kotlinx-datetime = "0.6.0"
okio = "3.9.0"

@roeierez
Copy link
Member

Thanks @angelix does it fix any issue you experienced or it is only about updating the dependencies?

@angelix
Copy link
Collaborator Author

angelix commented Jun 11, 2024

Thanks @angelix does it fix any issue you experienced or it is only about updating the dependencies?

Updating dependencies and better organize them.
I have plans to support Kotlin 2.0.0 & also desktop targets, but this will require a help from you to build the required binaries.

Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roeierez
Copy link
Member

@dangeross can you review this please?

@dangeross dangeross self-requested a review June 17, 2024 05:45
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it also brings the JNI version inline with the android bindings.

@angelix were you able to test locally, or shall we create a pre-release build so you can test?

@angelix
Copy link
Collaborator Author

angelix commented Jun 17, 2024

LGTM, it also brings the JNI version inline with the android bindings.

@angelix were you able to test locally, or shall we create a pre-release build so you can test?

@dangeross haven't test it, a pre-release would be great.

@dangeross dangeross merged commit 2225617 into breez:main Jun 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants