Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on sdk-common with liquid feature #452

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

erdemyerebasmaz
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz commented Aug 20, 2024

Changelist:

  • Depend on sdk-common with liquid feature
    • chore: ran cargo update
  • Add copy script to packages/react-native makefile
    • copy script is useful if uniffi bindings are recently generated, it saves time by not regenerating android, ios and rn bindings
    • Reordered scripts

@erdemyerebasmaz erdemyerebasmaz changed the title Add use_trampoline to LnUrlPayRequest and improve react-native script on bindings Add use_trampoline to LnUrlPayRequest Aug 20, 2024
Base automatically changed from prod-podspec-version-script to main August 20, 2024 11:51
@erdemyerebasmaz
Copy link
Contributor Author

erdemyerebasmaz commented Aug 20, 2024

We've decided to

on GL SDK.


This PR's scope has been changed to:

  • depend on sdk-common with liquid feature & generate bindings
  • add copy scripts to packages/react-native's makefile

Reviews will be re-requested once bindings are fully generated.

@erdemyerebasmaz erdemyerebasmaz changed the title Add use_trampoline to LnUrlPayRequest Depend on sdk-common with liquid feature Aug 20, 2024
Copy link
Contributor

@ok300 ok300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT, otherwise LGTM

lib/core/src/bindings.rs Outdated Show resolved Hide resolved
@erdemyerebasmaz erdemyerebasmaz merged commit 5248dfc into main Aug 20, 2024
7 checks passed
@erdemyerebasmaz erdemyerebasmaz deleted the lnurlpayreq-usetrampoline branch August 20, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants