-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on sdk-common
with liquid
feature
#452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok300
approved these changes
Aug 20, 2024
erdemyerebasmaz
force-pushed
the
lnurlpayreq-usetrampoline
branch
from
August 20, 2024 11:46
3fc56ac
to
ed3654a
Compare
erdemyerebasmaz
changed the title
Add
Add Aug 20, 2024
use_trampoline
to LnUrlPayRequest
and improve react-native
script on bindingsuse_trampoline
to LnUrlPayRequest
Reorder scripts
erdemyerebasmaz
force-pushed
the
lnurlpayreq-usetrampoline
branch
from
August 20, 2024 12:00
ed3654a
to
97d6099
Compare
We've decided to on GL SDK. This PR's scope has been changed to:
Reviews will be re-requested once bindings are fully generated. |
erdemyerebasmaz
changed the title
Add
Depend on Aug 20, 2024
use_trampoline
to LnUrlPayRequest
sdk-common
with liquid
feature
erdemyerebasmaz
force-pushed
the
lnurlpayreq-usetrampoline
branch
from
August 20, 2024 13:59
97a1163
to
d51f580
Compare
ok300
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One NIT, otherwise LGTM
Applies changes from - breez/breez-sdk-greenlight#1078
ok300
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist:
sdk-common
withliquid
featurecargo update
copy
script topackages/react-native
makefile
copy
script is useful if uniffi bindings are recently generated, it saves time by not regenerating android, ios and rn bindings