-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove auto-formatting command from tonic build #655
Conversation
I have noticed also an issue on windows and fixed that on the release branch with a solution that works cross platform: 6cf216e Do you think it is good enough or we need to remove the command as in this PR? |
@hydra-yse ping about my comment above. |
@roeierez We need to remove it as it's related more to using the SDK package as a rust dependency (regardless of platform). It will error out as it cannot find the .proto file during compilation |
2520a4f
to
f33b4bd
Compare
I've opted for ignoring the format command if it fails. So when it's used as a sub-dependency the build command won't fail. |
4a9853c
to
e260cc6
Compare
For future reference, there seems to be an open issue regarding We currently need the nightly toolchain in order to compile bindings, so for now I think the workaround of manually formatting is acceptable |
e260cc6
to
4945c11
Compare
4945c11
to
6b0fbef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: use `include_protos` macro instead of builder * fix: pin boltz to rev SatoshiPortal/boltz-rust@3bbc0dd
This breaks the SDK package when used as a sub-dependency of a rust project.