Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove auto-formatting command from tonic build #655

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

hydra-yse
Copy link
Member

This breaks the SDK package when used as a sub-dependency of a rust project.

@roeierez
Copy link
Member

I have noticed also an issue on windows and fixed that on the release branch with a solution that works cross platform: 6cf216e

Do you think it is good enough or we need to remove the command as in this PR?

@roeierez
Copy link
Member

@hydra-yse ping about my comment above.

@hydra-yse
Copy link
Member Author

hydra-yse commented Jan 14, 2025

I have noticed also an issue on windows and fixed that on the release branch with a solution that works cross platform: 6cf216e

Do you think it is good enough or we need to remove the command as in this PR?

@roeierez We need to remove it as it's related more to using the SDK package as a rust dependency (regardless of platform). It will error out as it cannot find the .proto file during compilation

@hydra-yse
Copy link
Member Author

I've opted for ignoring the format command if it fails. So when it's used as a sub-dependency the build command won't fail.

@hydra-yse hydra-yse force-pushed the yse-fix-build branch 8 times, most recently from 4a9853c to e260cc6 Compare January 15, 2025 09:05
@hydra-yse
Copy link
Member Author

For future reference, there seems to be an open issue regarding tonic_build output formatting using the nightly compiler: hyperium/tonic#868

We currently need the nightly toolchain in order to compile bindings, so for now I think the workaround of manually formatting is acceptable

Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydra-yse hydra-yse merged commit bb0b370 into main Jan 15, 2025
9 checks passed
hydra-yse added a commit that referenced this pull request Jan 15, 2025
* feat: use `include_protos` macro instead of builder
* fix: pin boltz to rev SatoshiPortal/boltz-rust@3bbc0dd
@hydra-yse hydra-yse deleted the yse-fix-build branch January 21, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants