schedule chain sync as unique work #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
reviewed
May 6, 2024
| @@ -31,6 +32,6 @@ private void startSyncJob(){ | |||
| .build()) | |||
| .build(); | |||
|
|
|||
| WorkManager.getInstance().enqueue(oneTime); | |||
| WorkManager.getInstance().enqueueUniqueWork(UNIQUE_WORK_NAME, ExistingWorkPolicy.REPLACE, oneTime); | |||
There was a problem hiding this comment.
@JssDWt did you consider using https://developer.android.com/reference/androidx/work/ExistingWorkPolicy#KEEP ? It looks like the difference is that it won't cancel the pending job and just let it finish.
There was a problem hiding this comment.
I did not consider that, that looks better indeed
There was a problem hiding this comment.
@roeierez Testing this out it seems the job is not executed when I use ExistingWorkPolicy.KEEP
JssDWt
force-pushed
the
jssdwt-deparallelize-chainsync
branch
from
1294cf0
to
0b025c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to deduplicate sync jobs at the root level, namely where they're scheduled.
Tested with a firebase notification. The job is still triggered at least. I'm not sure whether it will actually be deduplicated.