Testsuite compatibility with python 3.13 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 has started requiring the authorityKeyIdentifier field as per python/cpython#107361 . After iterating a bit, it appears that we only need to pass "-addext keyUsage=keyCertSign" to openssl during CA certificate creation and the server certificate will have the proper field. It's also possible to use something like `trustme` to generate the certificates but that would have been a much larger change and more work (maybe leading to most of the script being dropped however).
While this is not a security concern since this is for a test CA, this is future-proofing: DES3 is outdated and it is not impossible that it this usage does not become possible anymore in the future.
adrien-n
changed the title
|
Hi, please submit this on Launchpad (https://launchpad.net/brz) - breezy doesn't use GitHub for merging changes. |
|
Done: https://code.launchpad.net/~adrien/brz/brz/+merge/479089 . (my first PR/MR using bzr/brz) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breezy FTBFS in Ubuntu plucky due to tests, following the switch to python 3.13. This is a set of changes to solve that, plus a couple misc improvements.
The FTBFS was caused by two changes in python 3.13:
ssl.create_default_context(): addVERIFY_X509_STRICTandVERIFY_X509_PARTIAL_CHAINto the defaultverify_flagspython/cpython#107361