-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use with a custom runtime (that also extends SymfonyRuntime) #56
Comments
WIth my PR linked above, I got it working without needing to change anything but performance are still way worse i.e around 100ms for a /ping route vs ~17ms before with php-fpm layer , am I doing something wrong ? |
Are you using If not, then each request will be handled by a new process. If you do, then running the code in the kernel's constructor should have the same result as using a custom runtime. |
ah i thought BREF_LOOP_MAX was "unlimited" by default, and putting a number was to force-reboot to avoid memory leak, I will try that then ! (to be honest the doc was not clear about this parameter 👼 ) |
Ah interesting, if we could make that clearer in the README that might be better indeed. |
indeed with BREF_LOOP_MAX it works now, and OMG , my /ping was before 10ms -> now 2ms , my /dashboard was 140ms -> now 40ms !! |
by the way, do you know if now , with this method if the events that are done on a ec2 after |
The terminate event should still run synchronously (unless there were some amazing changes in Lambda). Maybe it runs much faster now for different reasons? |
ok, i will try to add some log, because it seems that unfortunately it does not work anymore with blackfire ^^ (or at least not with the CLI / plugin extensions ^^) |
I have a custom runtime that is like this
i.e it reads additional env variables from a kms-encrypted file
however if i try to use the version 0.2.0 wihtout php-fpm, it fails because the BrefRuntime is hardcoded.
Is there a way to do what I want with the bref/symfony-bridge as it is ? (i.e to get the env variables set-up, I don't mind not using 'my' runtime, as long as the job is done)
I got it working by moving this piece of code in the constructor of my kernel, but it degrades a lot the performance ( I think because now it needs to read the configuration at every request and not only cold ones ? )
The text was updated successfully, but these errors were encountered: