feat: improve rune scan

breml · Nov 2, 2021 · d73ee04 · d73ee04
1 parent 9b123bd
commit d73ee04
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pkg/bidichk/bidichk.go b/pkg/bidichk/bidichk.go
@@ -51,11 +51,14 @@ func check(filename string, pos token.Pos, pass *analysis.Pass) error {
 	for name, r := range disallowedRunes {
 		start := 0
 		for {
-			if !bytes.ContainsRune(body[start:], r) {
+			idx := bytes.IndexRune(body[start:], r)
+			if idx == -1 {
 				break
 			}
-			start += bytes.IndexRune(body[start:], r)
+			start += idx
+
 			pass.Reportf(pos+token.Pos(start), "found dangerous unicode character sequence %s", name)
+
 			start += utf8.RuneLen(r)
 		}
 	}