Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added funclatency, a tool for summarizing kernel function latencies #43

Closed
wants to merge 1 commit into from

Conversation

ryao
Copy link

@ryao ryao commented Jan 1, 2016

I really wanted histograms on function execution times, so I modified iolatency to get it.

Signed-off-by: Richard Yao ryao@gentoo.org

Signed-off-by: Richard Yao <ryao@gentoo.org>
@brendangregg
Copy link
Owner

brendangregg commented Jun 15, 2016

Sorry for the delay. I think this tool is simply too dangerous in terms of overhead to include, as it's passing every entry and return event to user space for post-processing. Users should be using BPF, which can do the summaries in-kernel, or at the very least, the ftrace capabilities for average latency.

I understand that people on older kernels may have no choice. I'd consider including this tool if by default it would not run, and printed a message saying something like:

This tool is a high-overhead hack for older kernels, that works by sending all function entry and return events to user space for post-processing. Please use tools based on BPF and Linux 4.x series (or newer) kernels to measure this efficiently. If you are desperate, and are willing to pay what may be severe overhead, and will test in a lab environment before use, then you can continue with -F to force. It's not recommend. You have been warned.

And implement a -F.

@brendangregg
Copy link
Owner

Closing; this is a job for BPF, or, post-processing funcslower(8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants