Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disjoint() and merge() #149

Merged
merged 3 commits into from
Jan 15, 2020
Merged

add disjoint() and merge() #149

merged 3 commits into from
Jan 15, 2020

Conversation

jyn514
Copy link
Collaborator

@jyn514 jyn514 commented Jan 14, 2020

I added lots of tests :)

Copy link
Owner

@brendanzab brendanzab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great - just have a few formatting nit-picks to apply! Nice work on the tests too!

codespan/src/span.rs Show resolved Hide resolved
codespan/src/span.rs Show resolved Hide resolved
jyn514 and others added 2 commits January 14, 2020 07:45
Co-Authored-By: Brendan Zabarauskas <bjzaba@yahoo.com.au>
Co-Authored-By: Brendan Zabarauskas <bjzaba@yahoo.com.au>
@jyn514
Copy link
Collaborator Author

jyn514 commented Jan 14, 2020

Addressed review comments.

@brendanzab
Copy link
Owner

Thanks!

@brendanzab brendanzab merged commit a795b49 into brendanzab:master Jan 15, 2020
brendanzab added a commit that referenced this pull request Feb 20, 2020
Thanks to #149 we don’t need a local implementation of this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants