Merge pull request #59 from miks/master

More reliable lower/higher item detection
brendon · Dec 4, 2012 · e74ea1a · e74ea1a
2 parents 094b39c + 33d943d
commit e74ea1a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/acts_as_list/active_record/acts/list.rb b/lib/acts_as_list/active_record/acts/list.rb
@@ -176,15 +176,17 @@ def last?
  def higher_item
  return nil unless in_list?
  acts_as_list_class.unscoped.find(:first, :conditions =>
- "#{scope_condition} AND #{position_column} = #{(send(position_column).to_i - 1).to_s}"
+ "#{scope_condition} AND #{position_column} < #{(send(position_column).to_i).to_s}",
+ :order => "#{acts_as_list_class.table_name}.#{position_column} DESC"
  )
  end
 
  # Return the next lower item in the list.
  def lower_item
  return nil unless in_list?
  acts_as_list_class.unscoped.find(:first, :conditions =>
- "#{scope_condition} AND #{position_column} = #{(send(position_column).to_i + 1).to_s}"
+ "#{scope_condition} AND #{position_column} > #{(send(position_column).to_i).to_s}",
+ :order => "#{acts_as_list_class.table_name}.#{position_column} ASC"
  )
  end