Fix regression with using acts_as_list on base classes #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123 introduced a regression, since
acts_as_list_class
now returns the subclass, not the superclass. My use-case is as follows:The application is an online course, which is composed of videos, quizzes, and exams. acts_as_list keeps these in order. However, after #123,
lower_item
will return the next item of the same subclass, skipping over other segments of other subclasses, which is not at all desired.If one desires this behavior, declaring
acts_as_list
on the subclasses separately makes sense. This PR reverts the regression, and includes tests for both use-cases.