Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails4 compatibility #80

Merged
merged 6 commits into from
Jul 28, 2013
Merged

Rails4 compatibility #80

merged 6 commits into from
Jul 28, 2013

Conversation

philippfranke
Copy link
Contributor

Acts as list doesn’t support rails4 yet so I changed a bit:

Rails 4 support: 💯

@conzett
Copy link
Contributor

conzett commented Apr 11, 2013

+1 from me 1.87 is almost EOL. Probably necessitates a bump in the major version number.

@javierjulio
Copy link

+1 thanks @philippfranke! Be great to get Rails 4 support in.

@swanandp
Copy link
Contributor

@philippfranke @conzett Let us merge the scope array fix and push a version out, we can then merge this and increment the major version number.

@eka
Copy link

eka commented Jun 28, 2013

+1

@javierjulio
Copy link

+1 - we are using acts_as_list and would be great if we could get this in so we can upgrade to Rails 4.

@conzett
Copy link
Contributor

conzett commented Jun 28, 2013

@philippfranke @swanandp Working on getting array scope stuff fixed up for 1.8.7 right now, so you can do that last minor release, sorry for delay. Edit: scope array fix is passing now.

@tibra
Copy link

tibra commented Jun 28, 2013

+1 @philippfranke – thank you!

@philippfranke
Copy link
Contributor Author

After #81 was merged, you can finally merge this pull( #80 ) as well.

/cc @swanandp

@javierjulio
Copy link

Thanks @philippfranke!

@chibicode
Copy link

👍

1 similar comment
@rimenes
Copy link

rimenes commented Jul 26, 2013

+1

@kolodovskyi
Copy link

Thanks! +1

@philippfranke
Copy link
Contributor Author

Finally, you can merge it. /cc @swanandp

@javierjulio
Copy link

👍

swanandp added a commit that referenced this pull request Jul 28, 2013
@swanandp swanandp merged commit d8d4155 into brendon:master Jul 28, 2013
@swanandp
Copy link
Contributor

Thanks @philippfranke!

@philippfranke philippfranke deleted the rails4_compatibility branch July 29, 2013 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants