-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implot demo: add link in the readme (+ minor warning fix) #43
Conversation
ImGui::Text(some_char_ptr) is dangerous because some_char_ptr could be a format string. This raises a justifiable warning in some compilers.
I have one question related to ImGui Bundle: I have to release a corrective patch to ImGui Bundle this week-end (because of issues not related to ImPlot3D). At the moment, I'm using your commit 653b302 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome to me
I moved my replies to #45, let's continue the conversation in that dicussion since this PR will be merged!
Wow this is amazing! I had no idea ImPlot3D could be ported to python when I started it kkkkkkk great to see it! I tried testing it locally following these commands: python -m venv .env
source .env/bin/activate.fish
pip install imgui-bundle
pip install opencv-python
pip install pyGLM
python imgui_bundle.py However, I got the following error: Traceback (most recent call last):
File "/home/breno/Downloads/bundle-test/imgui_bundle.py", line 1, in <module>
from imgui_bundle import imgui, immapp, implot3d
File "/home/breno/Downloads/bundle-test/imgui_bundle.py", line 1, in <module>
from imgui_bundle import imgui, immapp, implot3d
ImportError: cannot import name 'imgui' from partially initialized module 'imgui_bundle' (most likely due to a circular import) (/home/breno/Downloads/bundle-test/imgui_bundle.py) Here is the annotated-types==0.7.0
glfw==2.8.0
imgui-bundle==1.6.1
munch==4.0.0
numpy==2.2.1
opencv-python==4.10.0.84
pillow==11.1.0
pydantic==2.10.4
pydantic_core==2.27.2
PyGLM==2.7.3
PyOpenGL==3.1.7
typing_extensions==4.12.2 Let me know if I did something wrong! I would love to test the python bindings :)
I don't mind having two signatures for the
It is fine to use this commit for your release! I advise using the
Sounds very exciting, I'm looking forward to using it! |
Hi,
Following
#25
Here is a PR which adds a link to the demo in the Readme. If you have a better wording proposition please apply it. This is just a suggestion.
About ImGui Bundle integration:
By the way, I added ImPlot3D to ImGui bundle (see latest commits. It is now available in the C++ and Python side of Dear ImGui Bundle.
The integration went smoothly. I had to make a fork for implot3d, since one part of the API was impossible to port to python without manual adjustments (see this commit which adapts the API for PlotSurface for Python bindings)
As an example, here is a working python app with Implot3D: