Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Port/Add Description #33

Closed
migbro opened this issue Jan 24, 2024 · 2 comments
Closed

Feature Request: Port/Add Description #33

migbro opened this issue Jan 24, 2024 · 2 comments

Comments

@migbro
Copy link
Contributor

migbro commented Jan 24, 2024

Hi! I've been creating a reference of my own, and I noticed that the INFO Description from the source VCF is not carried over when I use an alias in the config (I haven't tried no alias). Would it be possible to use the original corresponding ##INFO header entry (aside from alias for ID) or to be able to specify in config (so like e.description)? I believe it can happen here: https://github.com/brentp/echtvar/blob/main/src/lib/echtvar.rs#L176-L194. I think it'd' also be good to keep/specify Number so as to comply with proper VCF specs. Thanks in advance!

@brentp
Copy link
Owner

brentp commented Jan 25, 2024

I like this idea!
Definitely open to a PR that implements this. It will have to modify the encoder command and extract the description there and save it to the archive.
I'll try to get around to implementing this, but it's not high on my priority list due to time limitations.

@migbro
Copy link
Contributor Author

migbro commented Feb 5, 2024

This was solved by PR #34 and PR #35, as of this comment, incorporated into main, but not release yet. Thanks for the help and review!

@migbro migbro closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants