Fix subcommand edge cases associated with generics, tyro.conf.Suppress
, tyro.conf.AvoidSubcomands
#220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now fixed:
tyro.conf.AvoidSubcommands
could unnecessarily narrow types when generic types were placed in unions.x: tyro.conf.Suppress[StructA | None] = None
was throwing an error if a default was missing fromStructA
.Example of one bug we had:
The help that we expect and now get is:
Compared to previously: