Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Unknown types at API boundaries #249

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Jan 30, 2025

Fixes #243

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (984c009) to head (029c411).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   99.78%   99.78%   -0.01%     
==========================================
  Files          28       28              
  Lines        2327     2326       -1     
==========================================
- Hits         2322     2321       -1     
  Misses          5        5              
Flag Coverage Δ
unittests 99.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi merged commit c5be357 into main Jan 30, 2025
17 checks passed
@brentyi brentyi deleted the brent/reduce_unknown_types branch January 30, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Minor Feature/Fix] Proper type annotations for tyro.conf.arg and tyro.conf.subcommand.
1 participant