Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore helptext behavior for erased argument names + tests #253

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Feb 10, 2025

#252 reverted the helptext grouping behavior discussed in #183 for when tyro.conf.arg(name="") is used. I restored this. The groupings that motivated #252 should be unaffected.

@brentyi brentyi merged commit a809c1e into main Feb 10, 2025
15 checks passed
@brentyi brentyi deleted the brent/erase_argname_compat branch February 10, 2025 10:26
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (971c839) to head (3648cd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          28       28           
  Lines        2246     2246           
=======================================
  Hits         2243     2243           
  Misses          3        3           
Flag Coverage Δ
unittests 99.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant