Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FluentVersioned Extension for Versioned collector #1

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

brettt89
Copy link
Owner

FluentVersionedCollectorExtension added for collecting data that is localised using Fluent.

Reference: https://github.com/tractorcow-farm/silverstripe-fluent/

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #1 (3425e9c) into master (314f48c) will decrease coverage by 16.26%.
The diff coverage is 70.86%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master       #1       +/-   ##
=============================================
- Coverage     90.72%   74.45%   -16.27%     
- Complexity       43      102       +59     
=============================================
  Files             7        8        +1     
  Lines            97      321      +224     
=============================================
+ Hits             88      239      +151     
- Misses            9       82       +73     
Flag Coverage Δ
unittests 74.45% <70.86%> (-16.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Extensions/FluentVersionedCollectorExtension.php 0.00% <0.00%> (ø)
src/Processors/AbstractProcessor.php 100.00% <ø> (ø)
src/Collectors/VersionedCollector.php 90.97% <90.97%> (ø)
src/GarbageCollectorService.php 94.59% <93.54%> (-5.41%) ⬇️
src/Collectors/ChangeSetCollector.php 94.44% <94.44%> (ø)
src/Collectors/AbstractCollector.php 100.00% <100.00%> (ø)
src/Processors/DataListProcessor.php 100.00% <100.00%> (ø)
src/Processors/SQLExpressionProcessor.php 94.11% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ae35c...3425e9c. Read the comment docs.

@brettt89 brettt89 force-pushed the feature/fluent-versioned-extension branch from 3425e9c to f1f45f5 Compare July 19, 2021 11:21
@brettt89 brettt89 merged commit 79ea902 into master Jul 19, 2021
@brettt89 brettt89 deleted the feature/fluent-versioned-extension branch July 19, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants