Hash Table complete with tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankieFabuloso
left a comment
FrankieFabuloso
left a comment
There was a problem hiding this comment.
Good job! Left some comments.
|
|
||
| put(key, value) { | ||
| let hashedKey = this.hash(key) | ||
| this.list[hashedKey] = new Node(key, value) |
There was a problem hiding this comment.
Are you at trying to implement your hashtable with collision chaining?
I think you might be missing the logic in doing so.
Personally, I think that you don't need to do it since you have already implemented a LinkedList and presumably know how it works so I think just knowing that you would use a LinkedList to handle collisions would suffice for the sake of completing all the other more difficult data structures.
But if you wanna handle collision chaining I would defs be able to talk through it with you, it has been a while since I've done it.
| if (!this.list[hashedKey]) { | ||
| return false | ||
| } | ||
| return this.list[hashedKey].key === key ? true : false |
There was a problem hiding this comment.
You can just return this.list[hashedKey].key === key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.