Skip to content

Commit

Permalink
Update packages/pg-pool/index.js
Browse files Browse the repository at this point in the history
Co-authored-by: Charmander <~@charmander.me>
  • Loading branch information
2 people authored and brianc committed Oct 20, 2020
1 parent e82137e commit 80c500f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/pg-pool/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ class Pool extends EventEmitter {
if (options != null && options.ssl && options.ssl.key) {
// "hiding" the ssl->key so it doesn't show up in stack traces
// or if the client is console.logged
this.options.ssl.key = options.ssl.key
Object.defineProperty(this.options.ssl, 'key', {
enumerable: false,

This comment has been minimized.

Copy link
@lukaszzdanikowski

lukaszzdanikowski Oct 28, 2020

shouldn't there be also value: options.ssl.key passed after enumerable: false?

This comment has been minimized.

Copy link
@charmander

charmander Oct 30, 2020

Author Collaborator

@lukaszzdanikowski Object.defineProperty can update an existing property, which should be the case here. (There’s a difference when key isn’t an own property, but that’s not supported.)

})
Expand Down

0 comments on commit 80c500f

Please sign in to comment.