test: Avoid silencing errors from idle timeout test’s child process (#3419)

This hid the error fixed in #3263, for example.

Author: charmander

packages/pg-pool/test/idle-timeout.js

@@ -89,28 +89,30 @@ describe('idle timeout', () => {
 
   it('unrefs the connections and timeouts so the program can exit when idle when the allowExitOnIdle option is set', function (done) {
     const child = fork(path.join(__dirname, 'idle-timeout-exit.js'), [], {
-      silent: true,
+      stdio: ['ignore', 'pipe', 'inherit', 'ipc'],
       env: { ...process.env, ALLOW_EXIT_ON_IDLE: '1' },
     })
     let result = ''
     child.stdout.setEncoding('utf8')
     child.stdout.on('data', (chunk) => (result += chunk))
     child.on('error', (err) => done(err))
-    child.on('close', () => {
+    child.on('exit', (exitCode) => {
+      expect(exitCode).to.equal(0)
       expect(result).to.equal('completed first\ncompleted second\n')
       done()
     })
   })
 
   it('keeps old behavior when allowExitOnIdle option is not set', function (done) {
     const child = fork(path.join(__dirname, 'idle-timeout-exit.js'), [], {
-      silent: true,
+      stdio: ['ignore', 'pipe', 'inherit', 'ipc'],
     })
     let result = ''
     child.stdout.setEncoding('utf8')
     child.stdout.on('data', (chunk) => (result += chunk))
     child.on('error', (err) => done(err))
-    child.on('close', () => {
+    child.on('exit', (exitCode) => {
+      expect(exitCode).to.equal(0)
       expect(result).to.equal('completed first\ncompleted second\nremoved\n')
       done()
     })