eslint: enable recommended ruleset #3263
Conversation
Also delete tests which have not been enabled since 2017.
|
@brianc is there anything I can do to help get this PR considered for review? |
Thanks for the feedback. I've reverted the unrelated changes. |
|
Oh, I see there are no code changes associated with this. How about applying the entire ESLint recommended configuration, then? |
alxndrsn
changed the title
I've done this, and updated the PR title to reflect the change. Eslint's ECMAScript version is bumped to 2020 as this was required to support node-postgres/.github/workflows/ci.yml Lines 40 to 45 in a9fd34f It's picked up some obvious errors, and some stuff which is more debatable. |
| @@ -11,7 +11,6 @@ if (module === require.main) { | |||
| pool.query('SELECT NOW()', (err, res) => console.log('completed first')) | |||
| pool.on('remove', () => { | |||
| console.log('removed') | |||
| done() | |||
There was a problem hiding this comment.
I haven’t really looked at this, but there’s probably more to do here than quietly deleting a line. Does none of this code run at all, then?
| return count | ||
| } | ||
| } | ||
| } while (Date.now() - start > time) |
There was a problem hiding this comment.
The logic here has been inverted.
| return count | ||
| } | ||
| } | ||
| } while (Date.now() - start > time) |
There was a problem hiding this comment.
The logic here has been inverted.
|
|
||
| const { length: OIDLength, index: indexAfterOIDLength } = readASN1Length(data, index) | ||
| index = indexAfterOIDLength | ||
| lastIndex = index + OIDLength | ||
| let lastIndex = index + OIDLength |
| @@ -225,7 +225,7 @@ suite.test('sasl/scram', function () { | |||
| 0x0d, // signature algorithm length | |||
| 0x06, // ASN.1 OID | |||
| 0x09, // OID length | |||
| 0x2a, // OID: 1.2.840.113549.1.1.11 (RSASSA-PKCS1-v1_5 / SHA-256) | |||
| 0x2a, // OID: 1.2.840.113549.1.1.11 (RSASSA-PKCS1-v1_5 / SHA-256) | |||
There was a problem hiding this comment.
(note for other readers: the difference is a zero-width space after “SHA-256”)
You can define |
No description provided.