Re-enable eslint with standard format #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to a clean slate with linting. We should add a lint check to Travis as well. That way going forward all PRs have to be clean prior to being merged. |
|
Yah travis is running the lint now as well. It was on earlier production branches, I just disabled it during work in progress on 7.0. Though up until 7.0 Feels good to finally update to more modern version of node and eslint. Good times ahead! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more semi-colons! 💃
Most of these changes were done with
standard --fix. There is still a bunch of cruft built up intest/directory that I'd like to clean out, but this is a good start and the code underlib/is fully checked. Upgrading to eslint will also allow the addition of new and stricter rules in the future.