Add no-verify ssl option #2198
Merged
Add no-verify ssl option #2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tgres into benhjames-bhsj/noverify
boromisp
reviewed
May 5, 2020
| case 'disable': | ||
| return false | ||
| case 'prefer': | ||
| case 'require': | ||
| case 'verify-ca': | ||
| case 'verify-full': | ||
| return true | ||
| // no-verify is not standard to libpq but allows specifying |
There was a problem hiding this comment.
If the intent is to follow the libpq behavior, then prefer should also skip certificate validation, and require only needs to validate the certificate if the root CA file is available.
Also, the checkServerIdentity should be disabled (set to no-op) if the mode is not verify-full.
There was a problem hiding this comment.
Yeah totally...but I'm probably not gonna change these - it's a semver major to change these and they've behaved this way since...kinda forever w/ pg. Slight inconsistencies w/ the native bindings aren't ideal, but they're less not-ideal than breaking changes. I will do a better job of documenting these options though in the docs and what they mean and how they diverge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds no-verify ssl option to
connection string parsing. You can pass
?ssl=no-verifyon the pg connection string & it will properly use{ rejectUnauthorized: false }in the ssl config passed totls.connect. Connecting with connection strings is common in heroku, and without this patch the connection info cannot be entirely contained within the connection string for heroku environments.environment variables. added support for
PGSSLMODE=no-verify.manually passing
new Client({ ssl: 'no-verify' }). The 3rd option isn't very common, but it will technically work.This is a backwards compatible, semver minor change.
Thanks to @benhjames for takin' the lead on this one 😄