Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in docs #3155

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix broken link in docs #3155

merged 2 commits into from
Mar 15, 2024

Conversation

runjak
Copy link
Contributor

@runjak runjak commented Feb 24, 2024

Hi 🙂 👋,

when browsing node-postgres.com/features/queries I noticed that the link to the types API a the bottom of the page appears to be broken. It seemed likely that the intention was to link to node-postgres.com/apis/types instead.

Similarly since api related documentation pages are hosted under /apis/ instead of /api/ I'd suggest adjusting the slugs in some cases.

@brianc
Copy link
Owner

brianc commented Feb 26, 2024

Thanks for your help! I have no idea why eslint stopped working...but I'll get that working so CI can pass.

@runjak
Copy link
Contributor Author

runjak commented Feb 26, 2024

Searching for the error of TypeError: prettier.resolveConfig.sync is not a function it appears that it could be related to an incompatibility between certain prettier and eslint versions. prettier/eslint-plugin-prettier#562 seems to be a good description of the issue.

I'm unclear if the yarn install in the .github/workflows/ci-yml:20 would correctly abide by potential lockfiles existing, or if it could just install newer possible versions of dependencies.

To me it seems that the issue here might be that current versions of some tooling may not play well together.
Reading https://stackoverflow.com/a/76625797/448591 it seems that updating eslint-plugin-prettier could alleviate the issue.


Edit:

Ah sorry for the noise, just noticed you're already looking into the issue independently at #3157

@brianc
Copy link
Owner

brianc commented Mar 6, 2024

Heeey sorry about that - this should be fixed now. Some crazy dependency update stuff happened which broke the build for a bit. Thankfully we got it solved! if you rebase on master we should be good to merge!

@runjak
Copy link
Contributor Author

runjak commented Mar 6, 2024

Hey no worries 🙂

Thanks for taking care and for the ping to rebase. Should be rebased now.

@brianc
Copy link
Owner

brianc commented Mar 13, 2024

Thanks for taking care and for the ping to rebase.

No problem! Its honestly the least I could do. What I should do is do the rebase myself & save you the trouble after already going through the work of opening a PR 😄 but I am turbo busy spinning down my job. In a few weeks I'll be free to focus on pg again!

@runjak
Copy link
Contributor Author

runjak commented Mar 13, 2024

Just did another rebase - just in case it aids the process 🙂

@brianc
Copy link
Owner

brianc commented Mar 13, 2024

Thanks! And apologize for the slowness. 😅

@charmander charmander merged commit aedae81 into brianc:master Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants