-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link in docs #3155
Fix broken link in docs #3155
Conversation
Thanks for your help! I have no idea why |
Searching for the error of I'm unclear if the To me it seems that the issue here might be that current versions of some tooling may not play well together. Edit: Ah sorry for the noise, just noticed you're already looking into the issue independently at #3157 |
Heeey sorry about that - this should be fixed now. Some crazy dependency update stuff happened which broke the build for a bit. Thankfully we got it solved! if you rebase on master we should be good to merge! |
Hey no worries 🙂 Thanks for taking care and for the ping to rebase. Should be rebased now. |
No problem! Its honestly the least I could do. What I should do is do the rebase myself & save you the trouble after already going through the work of opening a PR 😄 but I am turbo busy spinning down my job. In a few weeks I'll be free to focus on pg again! |
Just did another rebase - just in case it aids the process 🙂 |
Thanks! And apologize for the slowness. 😅 |
Hi 🙂 👋,
when browsing node-postgres.com/features/queries I noticed that the link to the types API a the bottom of the page appears to be broken. It seemed likely that the intention was to link to node-postgres.com/apis/types instead.
Similarly since api related documentation pages are hosted under
/apis/
instead of/api/
I'd suggest adjusting the slugs in some cases.