Bring native API in line with pure js version. Fixes #743 #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #743 the code breaks using
pg-native
where theResult.addRow
method is used.This method is missing from the native bindings because libpq loads all rows into memory before handing it to pg-native. The native bindings already simulate emitting row events, but does not replicate the addRow function.
I've added a test in
test/integration/client/simple-query-tests.js
usingResult.addRow
.And an empty function stub in
lib/native/result.js
which doesn't have to do anything sincepg-native
accumulates rows by default.