Consolidate the dependencies for the IsTerminal() API #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was already using golang.org/x/term for the IsTerminal() API. It seems better to stick to packages from the golang.org domain, because they are likely to be more widely used than github.com/mattn/go-isatty, and one less dependency is always a good thing. This can reduce the number of dependencies for consumers of github.com/briandowns/spinner, who may already have golang.org/x/term in their dependency chain.
|
Related: mattn/go-colorable#70 |
briandowns
reviewed
Jan 17, 2024
|
Thanks for the contribution! |
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Nov 1, 2024
Note that github.com/briandowns/spinner 1.18.1 introduced a needless
dependency on github.com/mattn/go-isatty for the IsTerminal() API, which
was later removed in 1.23.1 [1]. Fewer dependencies are always good
because it reduces the amount of code in use.
Therefore, this is a step towards using github.com/briandowns/spinner
1.23.1. Instead of bumping it straight to its final desired version,
doing it in smaller steps makes it easier to bisect any uncaught
regressions in future.
The src/go.sum file was updated with 'go mod tidy'.
[1] github.com/briandowns/spinner commit 8f269dd04fbfe236
briandowns/spinner@8f269dd04fbfe236
briandowns/spinner#156
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Nov 1, 2024
Note that github.com/briandowns/spinner 1.18.1 introduced a needless
dependency on github.com/mattn/go-isatty for the IsTerminal() API, which
was later removed in 1.23.1 [1]. Fewer dependencies are always good
because it reduces the amount of code in use.
Therefore, this is a step towards using github.com/briandowns/spinner
1.23.1. Instead of bumping it straight to its final desired version,
doing it in smaller steps makes it easier to bisect any uncaught
regressions in future.
The src/go.sum file was updated with 'go mod tidy'.
[1] github.com/briandowns/spinner commit 8f269dd04fbfe236
briandowns/spinner@8f269dd04fbfe236
briandowns/spinner#156
containers#1584
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Nov 1, 2024
Note that github.com/briandowns/spinner 1.18.1 introduced an undesired
dependency on github.com/mattn/go-isatty for the IsTerminal() API, which
was later removed in 1.23.1 [1]. Fewer dependencies are always good
because it reduces the amount of code in use.
Therefore, this is a step towards using github.com/briandowns/spinner
1.23.1. Instead of bumping it straight to its final desired version,
doing it in smaller steps makes it easier to bisect any uncaught
regressions in future.
The src/go.sum file was updated with 'go mod tidy'.
[1] github.com/briandowns/spinner commit 8f269dd04fbfe236
briandowns/spinner@8f269dd04fbfe236
briandowns/spinner#156
containers#1584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was already using golang.org/x/term for the IsTerminal() API. It seems better to stick to packages from the golang.org domain, because they are likely to be more widely used than github.com/mattn/go-isatty, and one less dependency is always a good thing.
This can reduce the number of dependencies for consumers of github.com/briandowns/spinner, who may already have golang.org/x/term in their dependency chain.