[dynamodb] Allow multiple credentials sources and types #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamodb binding was very strict about the credentials, it was mandatory to provide the credentials as a properties files, also, the credentials couldn't be temporary. This change adds two more options on top of the originally supported credentials: 1. It makes the `dynamodb.awsCredentialsFile` property optional, if this property is not given, the library will search for default credentials according to it's search rules that can be reviewed at: https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html 2. It adds one more supported property to the credentials file schema `sessionToken`, this adds the ability to generate and use temporary credentials from `aws sts` command. For more information: https://docs.aws.amazon.com/cli/latest/reference/sts/get-session-token.html#get-session-token This has been tested against DynamoDB with all 3 methods. Signed-off-by: Eliran Sinvani <eliransin@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamodb binding was very strict about the credentials, it was mandatory to provide the credentials as a properties files, also, the credentials couldn't be temporary.
This change adds two more options on top of the originally supported credentials:
dynamodb.awsCredentialsFileproperty optional, if this property is not given, the library will search for default credentials according to it's search rules that can be reviewed at: https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.htmlsessionToken, this adds the ability to generate and use temporary credentials fromaws stscommand. For more information: https://docs.aws.amazon.com/cli/latest/reference/sts/get-session-token.html#get-session-tokenThis has been tested against DynamoDB with all 3 methods.
Signed-off-by: Eliran Sinvani eliransin@scylladb.com