feat: make JDBC connection URL delimiter configurable #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the JDBC connection URL delimiter configurable. The current delimiter is semicolon ';', which breaks JDBC drivers that use semicolons in the actual connection URL. The default delimiter remains semicolon for all databases, except a list of databases that are known to use semicolons in the connection URL. Users can always specifiy a custom delimiter to work around any issues with the default delimiter. Fixes brianfrankcooper#1458
|
@busbey @allanbank @kruthar Friendly ping. Any chance that we could get a review for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the JDBC connection URL delimiter configurable. The current delimiter is semicolon ';', which breaks JDBC drivers that use semicolons in the actual connection URL. The default delimiter remains semicolon for all databases, except a list of databases that are known to use semicolons in the connection URL. Users can always specifiy a custom delimiter to work around any issues with the default delimiter.
Fixes #1458