Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brianguenter/issue67 #75

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Brianguenter/issue67 #75

merged 6 commits into from
Apr 17, 2024

Commits on Apr 10, 2024

  1. make_function returns wrong result with sparse Jacobian for very si… 

    …mple functions only

Fixes #67

added NoOp Node type and wrapped all roots in NoOp to ensure that nodes used in multiple roots all get edges.
    @brianguenter
    brianguenter committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4953981 View commit details
    Browse the repository at this point in the history

  2. moved wrapping of roots into top level of DerivativeGraph constructor.

    @brianguenter
    brianguenter committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f6d79ce View commit details
    Browse the repository at this point in the history

  3. fixing tests that no longer work because of NoOp change. Still more t… 

    …o do.
    @brianguenter
    brianguenter committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1bbb35b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. make_function returns wrong result with sparse Jacobian for very si… 

    …mple functions only

Fixes #67

fixed minor errors in test functions, @Assert -> @test, stuff like that.
    @brianguenter
    brianguenter committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    86e1401 View commit details
    Browse the repository at this point in the history

  2. changed DerivativeGraph constructor to copy roots into new array. Oth… 

    …erwise tried to index into things that can't be indexed into
    @brianguenter
    brianguenter committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f33c60d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. make_function returns wrong result with sparse Jacobian for very si… 

    …mple functions only

Fixes #67
all tests pass locally
    @brianguenter
    brianguenter committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    406f7c9 View commit details
    Browse the repository at this point in the history