Update scikit-learn to v0.24 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change deprecated sklearn.cluster.k_means_ in favor of sklearn.cluster._kmeans Updated geosketch version to 1.2
|
Thanks so much for the PR @prete! I cloned your version and ran it, and it does look good to me. Thanks especially for the changes to the non-geosketch portions of the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change: Updated scikit-learn dependency to v0.24.
In v0.24
sklearn.cluster.k_means_was deprecated so it's been changed tosklearn.cluster._kmeansinkmeanspp.py. The idea behind that is that it would be useful for this package not to have an old dependency onscikit-learn<=0.22.Additional minor fixes:
reduce_dimensionalityerror messagescanpy.apiinterface in favor of justscanpy1.2Disclaimer: didn't find any test to run on the package, so you may want to double check the new ouptus.