Add lint when comparing floats in an array

Finishes rust-lang#4277
briankabiro · Sep 17, 2019 · 11197c5 · 11197c5
1 parent c3e9136
commit 11197c5
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
@@ -519,7 +519,13 @@ fn is_signum(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
 }
 
 fn is_float(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
- matches!(walk_ptrs_ty(cx.tables.expr_ty(expr)).sty, ty::Float(_))
+ let value = &walk_ptrs_ty(cx.tables.expr_ty(expr)).sty;
+
+ if let ty::Array(arr_ty, _) = value {
+ return matches!(arr_ty.sty, ty::Float(_));
+ };
+
+ matches!(value, ty::Float(_))
 }
 
 fn check_to_owned(cx: &LateContext<'_, '_>, expr: &Expr, other: &Expr) {