Run rustfmt #22
Run rustfmt #22
Conversation
@nrc made a great tool, so use it for formatting.
| Ok(m) => { m } | ||
| Ok(m) => { | ||
| m | ||
| } |
There was a problem hiding this comment.
this might be worse
|
/cc @nrc |
| *reftype == "tags") => branch, | ||
| _ => return Err("could not unpack `ref`"), | ||
| } | ||
| .to_string() |
There was a problem hiding this comment.
This should be fixed in the latest rustfmt
|
Is rustfmt making decisions based on an RFC? I'm wondering if some of the rules that led it to changes just indentation level could/should be implemented in https://github.com/rust-lang/rust-mode |
| Ok(v) => Some(v), | ||
| Err(err) => return Err(err), | ||
| }, | ||
| Ok(v) => Some(v), |
There was a problem hiding this comment.
@steveklabnik This one and the one below also look wrong to me
|
I cherry-picked the parts I was sure made an improvement (most of the changes) but broke the merge by rearranging some |
|
@brianloveswords there has been one RFC for function decls, but it was inconclusive. Rustfmt is heavily customisable at the moment. Once it is working really well (can be run reliably on the main repo, for example) and thus it is easy to do mass changes to formatting, I'll start more RFCs to nail down the style. |
|
Closing this because I pulled out the relevant stuff, thanks for pointing me towards rustfmt @steveklabnik (and thanks for making it @nrc!). I'll keep running it as I work on this and file any issues I see with the results 👍 |
|
👍 |
|
I read this as "rust, fml" |
Please review carefully, as rustfmt is still under development and it might be a bit weird in places. We can fix anything that looks odd.
Includes #21 because it turns out it matters.