Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-unique id="email" attributes #398

Merged
merged 2 commits into from
Dec 28, 2019
Merged

Fix non-unique id="email" attributes #398

merged 2 commits into from
Dec 28, 2019

Conversation

zingerj
Copy link
Contributor

@zingerj zingerj commented Dec 27, 2019

Noticed this DevTools warning about non-unique IDs while looking into #397

brianlovin
brianlovin approved these changes Dec 28, 2019
View reviewed changes
Copy link
Owner

@brianlovin brianlovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch as well, thank you for the fix!

@brianlovin brianlovin merged commit ba62212 into brianlovin:master Dec 28, 2019
@zingerj zingerj deleted the fix-email-id branch December 28, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlovin brianlovin brianlovin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingerj @brianlovin