Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark notes #647

Merged
merged 5 commits into from
May 9, 2020
Merged

Bookmark notes #647

merged 5 commits into from
May 9, 2020

Conversation

brianlovin
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented May 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/brianlovin/brian-lovin-next/rm56dmq96
✅ Preview: https://brian-lovin-next-git-bookmark-notes.brianlovin.now.sh

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

style={{ width: '100%' }}
/>
{url.length > 0 && (
<React.Fragment>
<Textarea placeholder="Notes..." onChange={onNotesChange} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

placeholder="Title"
value={state.title}
onChange={onTitleChange}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

placeholder="Notes..."
value={state.notes}
onChange={onNotesChange}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2020

Images automagically compressed by Calibre's image-actions

Compression reduced images by 22.3%, saving 51.93 KB

Filename Before After Improvement
public/static/img/overthought/2019-in-review.png 12.12 KB 9.54 KB -21.3%
public/static/img/overthought/adding-dark-mode-with-next-js.png 24.40 KB 19.25 KB -21.1%
public/static/img/overthought/automating-the-boring-parts-of-product-design.png 18.57 KB 14.46 KB -22.1%
public/static/img/overthought/caching-api-routes-with-next-js.png 17.33 KB 13.50 KB -22.1%
public/static/img/overthought/cookies-authenticate-next-js-apollo-graphql-requests.png 23.87 KB 18.25 KB -23.6%
public/static/img/overthought/death-of-designer-unicorns.png 15.54 KB 11.99 KB -22.8%
public/static/img/overthought/incrementally-correct-personal-websites.png 17.93 KB 13.93 KB -22.3%
public/static/img/overthought/investing-for-designers-and-developers.png 19.77 KB 15.36 KB -22.3%
public/static/img/overthought/migrating-from-google-analytics-to-fathom.png 18.10 KB 14.05 KB -22.4%
public/static/img/overthought/on-working-nights-and-weekends.png 16.51 KB 12.85 KB -22.2%
public/static/img/overthought/product-design-portfolios.png 14.06 KB 11.04 KB -21.5%
public/static/img/overthought/the-meta-skills-of-product-design.png 16.09 KB 12.54 KB -22.0%
public/static/img/overthought/using-ghost-headless-cms-next-js-to-create-a-fast-and-simple-blog.png 18.99 KB 14.60 KB -23.1%
Some images were already optimised
  • public/static/img/about.jpg
  • public/static/img/podcasts/designdetails.jpg
  • public/static/img/subscription_icons/breaker.png
  • public/static/img/subscription_icons/castro.png
  • public/static/img/subscription_icons/google-podcasts.png
  • public/static/img/subscription_icons/overcast.png
  • public/static/img/subscription_icons/pocketcasts.png
  • public/static/img/subscription_icons/podcasts.png
  • public/static/img/subscription_icons/rss.png
  • public/static/img/subscription_icons/spotify.png
  • public/static/meta/app-dissection.png
  • public/static/meta/apple-touch-icon.png
  • public/static/meta/bookmarks.png
  • public/static/meta/google-touch-icon.png
  • public/static/meta/og-image.png
  • public/static/meta/overthought.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant