Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add og image and meta tags #649

Merged
merged 5 commits into from
May 9, 2020
Merged

Add og image and meta tags #649

merged 5 commits into from
May 9, 2020

Conversation

brianlovin
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented May 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/brianlovin/brian-lovin-next/k23o8nvey
✅ Preview: https://brian-lovin-next-git-ama-meta.brianlovin.now.sh

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2020

Images automagically compressed by Calibre's image-actions

Compression reduced images by 26.9%, saving 5.02 KB

Filename Before After Improvement
public/static/meta/ama.png 18.67 KB 13.65 KB -26.9%
Some images were already optimised
  • public/static/img/about.jpg
  • public/static/img/overthought/2019-in-review.png
  • public/static/img/overthought/adding-dark-mode-with-next-js.png
  • public/static/img/overthought/automating-the-boring-parts-of-product-design.png
  • public/static/img/overthought/caching-api-routes-with-next-js.png
  • public/static/img/overthought/cookies-authenticate-next-js-apollo-graphql-requests.png
  • public/static/img/overthought/death-of-designer-unicorns.png
  • public/static/img/overthought/incrementally-correct-personal-websites.png
  • public/static/img/overthought/investing-for-designers-and-developers.png
  • public/static/img/overthought/migrating-from-google-analytics-to-fathom.png
  • public/static/img/overthought/on-working-nights-and-weekends.png
  • public/static/img/overthought/product-design-portfolios.png
  • public/static/img/overthought/the-meta-skills-of-product-design.png
  • public/static/img/overthought/using-ghost-headless-cms-next-js-to-create-a-fast-and-simple-blog.png
  • public/static/img/podcasts/designdetails.jpg
  • public/static/img/subscription_icons/breaker.png
  • public/static/img/subscription_icons/castro.png
  • public/static/img/subscription_icons/google-podcasts.png
  • public/static/img/subscription_icons/overcast.png
  • public/static/img/subscription_icons/pocketcasts.png
  • public/static/img/subscription_icons/podcasts.png
  • public/static/img/subscription_icons/rss.png
  • public/static/img/subscription_icons/spotify.png
  • public/static/meta/app-dissection.png
  • public/static/meta/apple-touch-icon.png
  • public/static/meta/bookmarks.png
  • public/static/meta/google-touch-icon.png
  • public/static/meta/og-image.png
  • public/static/meta/overthought.png

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

height: '16px',
borderRadius: '16px',
}}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant